folkert/KEK
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

coverity: auto and &

Browse source
This commit is contained in:
folkert van heusden 2024-04-28 01:21:39 +02:00
parent b3932c2100
commit 2238243940
Signed by untrusted user who does not match committer: folkert
GPG key ID: 6B6455EDFEED3BD1
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
console_ncurses.cpp
View file

@ -187,11 +187,11 @@ void console_ncurses::panel_update_thread()
auto psw = data["psw"][0]; auto psw = data["psw"][0];
std::string instruction_values; std::string instruction_values;
for(auto iv : data["instruction-values"]) for(auto & iv : data["instruction-values"])
instruction_values += (instruction_values.empty() ? "" : ",") + iv; instruction_values += (instruction_values.empty() ? "" : ",") + iv;
std::string work_values; std::string work_values;
for(auto wv : data["work-values"]) for(auto & wv : data["work-values"])
work_values += (work_values.empty() ? "" : ",") + wv; work_values += (work_values.empty() ? "" : ",") + wv;
std::string instruction = data["instruction-text"].at(0); std::string instruction = data["instruction-text"].at(0);

8
debugger.cpp
View file

@ -325,11 +325,11 @@ int disassemble(cpu *const c, console *const cnsl, const uint16_t pc, const bool
auto psw = data["psw"][0]; auto psw = data["psw"][0];
std::string instruction_values; std::string instruction_values;
for(auto iv : data["instruction-values"]) for(auto & iv : data["instruction-values"])
instruction_values += (instruction_values.empty() ? "" : ",") + iv; instruction_values += (instruction_values.empty() ? "" : ",") + iv;
std::string work_values; std::string work_values;
for(auto wv : data["work-values"]) for(auto & wv : data["work-values"])
work_values += (work_values.empty() ? "" : ",") + wv; work_values += (work_values.empty() ? "" : ",") + wv;
std::string instruction = data["instruction-text"].at(0); std::string instruction = data["instruction-text"].at(0);
@ -391,7 +391,7 @@ std::map<std::string, std::string> split(const std::vector<std::string> & kv_arr
{ {
std::map<std::string, std::string> out; std::map<std::string, std::string> out;
for(auto pair : kv_array) { for(auto & pair : kv_array) {
auto kv = split(pair, splitter); auto kv = split(pair, splitter);
if (kv.size() == 1) if (kv.size() == 1)
@ -663,7 +663,7 @@ void debugger(console *const cnsl, bus *const b, std::atomic_uint32_t *const sto
cnsl->put_string_lf("Breakpoints:"); cnsl->put_string_lf("Breakpoints:");
for(auto a : bps) for(auto & a : bps)
cnsl->put_string_lf(format("%d: %s", a.first, a.second->emit().c_str())); cnsl->put_string_lf(format("%d: %s", a.first, a.second->emit().c_str()));
if (bps.empty()) if (bps.empty())