folkert/python-pdp1170
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sure no illegal values outside 16 bit range loaded via loadphysmem

Browse source
This commit is contained in:
Neil Webber 2024-04-23 07:39:18 -05:00
parent 6e54a9dc9e
commit 872ad7833d
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pdptests.py
View file

@ -57,6 +57,9 @@ class TestMethods(unittest.TestCase):
@staticmethod @staticmethod
def loadphysmem(p, words, addr): def loadphysmem(p, words, addr):
for a, w in enumerate(words, start=(addr >> 1)): for a, w in enumerate(words, start=(addr >> 1)):
# make sure no bogus values get into memory
if w < 0 or w > 65535:
raise ValueError(f"Illegal value {w} in loadphysmem")
p.physmem[a] = w p.physmem[a] = w
# some of these can't be computed at class definition time, so... # some of these can't be computed at class definition time, so...
@ -198,13 +201,13 @@ class TestMethods(unittest.TestCase):
a.mov('r0', 'sp') a.mov('r0', 'sp')
a.halt() a.halt()
a.literal(0o111111) a.literal(0o111111)
a.literal(0o777777) a.literal(0o177777)
a.label('stack') a.label('stack')
p = self.make_pdp() p = self.make_pdp()
self.loadphysmem(p, a, 0o10000) self.loadphysmem(p, a, 0o10000)
p.run(pc=0o10000) p.run(pc=0o10000)
self.assertEqual(p.mmu.wordRW(p.r[6] - 2), 0o777777) self.assertEqual(p.mmu.wordRW(p.r[6] - 2), 0o177777)
self.assertEqual(p.mmu.wordRW(p.r[6] - 4), 0o111111) self.assertEqual(p.mmu.wordRW(p.r[6] - 4), 0o111111)
# these tests end up testing other stuff too of course, including MMU # these tests end up testing other stuff too of course, including MMU