folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PDP11, PDP8, VAX8200: Fix Coverity flagged warnings

Browse source
This commit is contained in:
Mark Pizzolato 2019-10-20 22:57:02 -07:00
parent 0f72a160fe
commit 281837c68a
3 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
PDP11/pdp11_ta.c
View file

@ -301,8 +301,9 @@ if ((fnc != TACS_REW) && !(flg & OP_WRI)) { /* spc/read cmd? */
} }
if ((old_ust ^ uptr->UST) == (UST_REV|UST_GAP)) { /* reverse in gap? */ if ((old_ust ^ uptr->UST) == (UST_REV|UST_GAP)) { /* reverse in gap? */
if (uptr->UST) /* skip file gap */ if (uptr->UST) /* skip file gap */
sim_tape_rdrecr (uptr, ta_xb, &t, TA_MAXFR); (void)sim_tape_rdrecr (uptr, ta_xb, &t, TA_MAXFR);
else sim_tape_rdrecf (uptr, ta_xb, &t, TA_MAXFR); else
(void)sim_tape_rdrecf (uptr, ta_xb, &t, TA_MAXFR);
if (DEBUG_PRS (ta_dev)) if (DEBUG_PRS (ta_dev))
fprintf (sim_deb, ">>TA skip gap: op=%o, old_sta = %o, pos=%d\n", fprintf (sim_deb, ">>TA skip gap: op=%o, old_sta = %o, pos=%d\n",
fnc, uptr->UST, uptr->pos); fnc, uptr->UST, uptr->pos);

5
PDP8/pdp8_ct.c
View file

@ -329,8 +329,9 @@ if ((ct_sra & SRA_ENAB) && (uptr->flags & UNIT_ATT)) { /* enabled, att? */
">>CT skip gap: op=%o, old_sta = %o, pos=%d\n", ">>CT skip gap: op=%o, old_sta = %o, pos=%d\n",
fnc, uptr->UST, uptr->pos); fnc, uptr->UST, uptr->pos);
if (uptr->UST) /* skip file gap */ if (uptr->UST) /* skip file gap */
sim_tape_rdrecr (uptr, ct_xb, &t, CT_MAXFR); (void)sim_tape_rdrecr (uptr, ct_xb, &t, CT_MAXFR);
else sim_tape_rdrecf (uptr, ct_xb, &t, CT_MAXFR); else
(void)sim_tape_rdrecf (uptr, ct_xb, &t, CT_MAXFR);
} }
} }
else uptr->UST = 0; else uptr->UST = 0;

6
VAX/vax820_stddev.c
View file

@ -988,7 +988,7 @@ return SCPE_OK;
int32 fl_rd (int32 pa) int32 fl_rd (int32 pa)
{ {
int32 rg = (pa >> 1) & 0xF; int32 rg = (pa >> 1) & 0xF;
int32 val; int32 val = 0;
switch (rg) { switch (rg) {
@ -1032,10 +1032,6 @@ switch (rg) {
else /* no, disk 0 */ else /* no, disk 0 */
sim_activate (&fl_unit[0], fl_cwait); /* start operation */ sim_activate (&fl_unit[0], fl_cwait); /* start operation */
break; break;
default:
val = 0;
break;
} }
sim_debug (FL_DB_REG, &fl_dev, "fl_rd(%s) data=0x%02X\n", fl_regnames[rg], val); sim_debug (FL_DB_REG, &fl_dev, "fl_rd(%s) data=0x%02X\n", fl_regnames[rg], val);
return val; return val;