folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

This fixes the problem that MMR1 is recording changes to R7 (PC), which it should not. (issue #44)

Browse source 
It does not fix the problem that MMR1 is not used for floating point instructions.

I don't know if I will fix the FP MMR1 problem. It does not seem to impact running software. It is consistent with the architecture spec - just not with the actual J11 implementation. The J11 microcode has a variety of exception exits for FP conditions, and I have to trace which ones invoke fix-up, and which do not.
This commit is contained in:
Mark Pizzolato 2013-06-02 06:52:32 -07:00
parent 486ef58595
commit 4064cc079a
2 changed files with 27 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
PDP11/pdp11_cpu.c
View file

@ -1,6 +1,6 @@
/* pdp11_cpu.c: PDP-11 CPU simulator /* pdp11_cpu.c: PDP-11 CPU simulator
Copyright (c) 1993-2012, Robert M Supnik Copyright (c) 1993-2013, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"), copy of this software and associated documentation files (the "Software"),
@ -25,6 +25,7 @@
cpu PDP-11 CPU cpu PDP-11 CPU
10-Apr-13 RMS MMR1 does not track PC changes (Johnny Billquist)
29-Apr-12 RMS Fixed compiler warning (Mark Pizzolato) 29-Apr-12 RMS Fixed compiler warning (Mark Pizzolato)
19-Mar-12 RMS Fixed declaration of sim_switches (Mark Pizzolato) 19-Mar-12 RMS Fixed declaration of sim_switches (Mark Pizzolato)
29-Dec-08 RMS Fixed failure to clear cpu_bme on RESET (Walter Mueller) 29-Dec-08 RMS Fixed failure to clear cpu_bme on RESET (Walter Mueller)
@ -689,7 +690,8 @@ if (abortval != 0) {
if ((trapea > 0) && stop_vecabort) if ((trapea > 0) && stop_vecabort)
reason = STOP_VECABORT; reason = STOP_VECABORT;
if ((trapea < 0) && /* stack push abort? */ if ((trapea < 0) && /* stack push abort? */
(CPUT (STOP_STKA) || stop_spabort)) reason = STOP_SPABORT; (CPUT (STOP_STKA) || stop_spabort))
reason = STOP_SPABORT;
if (trapea == ~MD_KER) { /* kernel stk abort? */ if (trapea == ~MD_KER) { /* kernel stk abort? */
setTRAP (TRAP_RED); setTRAP (TRAP_RED);
setCPUERR (CPUE_RED); setCPUERR (CPUE_RED);
@ -907,7 +909,8 @@ while (reason == 0) {
trap_req = calc_ints (ipl, trap_req); trap_req = calc_ints (ipl, trap_req);
JMP_PC (src); JMP_PC (src);
if (CPUT (HAS_RTT) && tbit && /* RTT impl? */ if (CPUT (HAS_RTT) && tbit && /* RTT impl? */
(IR == 000002)) setTRAP (TRAP_TRC); /* RTI immed trap */ (IR == 000002))
setTRAP (TRAP_TRC); /* RTI immed trap */
break; break;
case 7: /* MFPT */ case 7: /* MFPT */
if (CPUT (HAS_MFPT)) /* implemented? */ if (CPUT (HAS_MFPT)) /* implemented? */
@ -1352,7 +1355,8 @@ while (reason == 0) {
} }
else { else {
dst = srcreg? R[srcspec]: ReadW (GeteaW (srcspec)); dst = srcreg? R[srcspec]: ReadW (GeteaW (srcspec));
if (!dstreg) ea = GeteaW (dstspec); if (!dstreg)
ea = GeteaW (dstspec);
} }
N = GET_SIGN_W (dst); N = GET_SIGN_W (dst);
Z = GET_Z (dst); Z = GET_Z (dst);
@ -1888,6 +1892,7 @@ while (reason == 0) {
R[dstspec] = (R[dstspec] & 0177400) | dst; R[dstspec] = (R[dstspec] & 0177400) | dst;
else PWriteB (dst, last_pa); else PWriteB (dst, last_pa);
break; break;
/* Notes: /* Notes:
- MTPS cannot alter the T bit - MTPS cannot alter the T bit
- MxPD must mask GeteaW returned address, dspace is from cm not pm - MxPD must mask GeteaW returned address, dspace is from cm not pm
@ -1981,7 +1986,8 @@ while (reason == 0) {
} }
else { else {
dst = srcreg? R[srcspec] & 0377: ReadB (GeteaB (srcspec)); dst = srcreg? R[srcspec] & 0377: ReadB (GeteaB (srcspec));
if (!dstreg) ea = GeteaB (dstspec); if (!dstreg)
ea = GeteaB (dstspec);
} }
N = GET_SIGN_B (dst); N = GET_SIGN_B (dst);
Z = GET_Z (dst); Z = GET_Z (dst);
@ -2161,20 +2167,20 @@ switch (spec >> 3) { /* decode spec<5:3> */
case 2: /* (R)+ */ case 2: /* (R)+ */
R[reg] = ((adr = R[reg]) + 2) & 0177777; R[reg] = ((adr = R[reg]) + 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (020 | reg); MMR1 = calc_MMR1 (020 | reg);
return (adr | ds); return (adr | ds);
case 3: /* @(R)+ */ case 3: /* @(R)+ */
R[reg] = ((adr = R[reg]) + 2) & 0177777; R[reg] = ((adr = R[reg]) + 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (020 | reg); MMR1 = calc_MMR1 (020 | reg);
adr = ReadW (adr | ds); adr = ReadW (adr | ds);
return (adr | dsenable); return (adr | dsenable);
case 4: /* -(R) */ case 4: /* -(R) */
adr = R[reg] = (R[reg] - 2) & 0177777; adr = R[reg] = (R[reg] - 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (0360 | reg); MMR1 = calc_MMR1 (0360 | reg);
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);
@ -2182,7 +2188,7 @@ switch (spec >> 3) { /* decode spec<5:3> */
case 5: /* @-(R) */ case 5: /* @-(R) */
adr = R[reg] = (R[reg] - 2) & 0177777; adr = R[reg] = (R[reg] - 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (0360 | reg); MMR1 = calc_MMR1 (0360 | reg);
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);
@ -2219,13 +2225,13 @@ switch (spec >> 3) { /* decode spec<5:3> */
case 2: /* (R)+ */ case 2: /* (R)+ */
delta = 1 + (reg >= 6); /* 2 if R6, PC */ delta = 1 + (reg >= 6); /* 2 if R6, PC */
R[reg] = ((adr = R[reg]) + delta) & 0177777; R[reg] = ((adr = R[reg]) + delta) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 ((delta << 3) | reg); MMR1 = calc_MMR1 ((delta << 3) | reg);
return (adr | ds); return (adr | ds);
case 3: /* @(R)+ */ case 3: /* @(R)+ */
R[reg] = ((adr = R[reg]) + 2) & 0177777; R[reg] = ((adr = R[reg]) + 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (020 | reg); MMR1 = calc_MMR1 (020 | reg);
adr = ReadW (adr | ds); adr = ReadW (adr | ds);
return (adr | dsenable); return (adr | dsenable);
@ -2233,7 +2239,7 @@ switch (spec >> 3) { /* decode spec<5:3> */
case 4: /* -(R) */ case 4: /* -(R) */
delta = 1 + (reg >= 6); /* 2 if R6, PC */ delta = 1 + (reg >= 6); /* 2 if R6, PC */
adr = R[reg] = (R[reg] - delta) & 0177777; adr = R[reg] = (R[reg] - delta) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 ((((-delta) & 037) << 3) | reg); MMR1 = calc_MMR1 ((((-delta) & 037) << 3) | reg);
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);
@ -2241,7 +2247,7 @@ switch (spec >> 3) { /* decode spec<5:3> */
case 5: /* @-(R) */ case 5: /* @-(R) */
adr = R[reg] = (R[reg] - 2) & 0177777; adr = R[reg] = (R[reg] - 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = calc_MMR1 (0360 | reg); MMR1 = calc_MMR1 (0360 | reg);
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);

11
PDP11/pdp11_fp.c
View file

@ -1,6 +1,6 @@
/* pdp11_fp.c: PDP-11 floating point simulator (32b version) /* pdp11_fp.c: PDP-11 floating point simulator (32b version)
Copyright (c) 1993-2008, Robert M Supnik Copyright (c) 1993-2013, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"), copy of this software and associated documentation files (the "Software"),
@ -23,6 +23,7 @@
used in advertising or otherwise to promote the sale, use or other dealings used in advertising or otherwise to promote the sale, use or other dealings
in this Software without prior written authorization from Robert M Supnik. in this Software without prior written authorization from Robert M Supnik.
20-Apr-13 RMS MMR1 does not track PC changes (Johnny Billquist)
22-Sep-05 RMS Fixed declarations (Sterling Garwood) 22-Sep-05 RMS Fixed declarations (Sterling Garwood)
04-Oct-04 RMS Added FIS instructions 04-Oct-04 RMS Added FIS instructions
19-Jan-03 RMS Changed mode definitions for Apple Dev Kit conflict 19-Jan-03 RMS Changed mode definitions for Apple Dev Kit conflict
@ -584,20 +585,20 @@ switch (spec >> 3) { /* case on spec */
if (reg == 7) if (reg == 7)
len = 2; len = 2;
R[reg] = ((adr = R[reg]) + len) & 0177777; R[reg] = ((adr = R[reg]) + len) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = (len << 3) | reg; MMR1 = (len << 3) | reg;
return (adr | ds); return (adr | ds);
case 3: /* @(R)+ */ case 3: /* @(R)+ */
R[reg] = ((adr = R[reg]) + 2) & 0177777; R[reg] = ((adr = R[reg]) + 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = 020 | reg; MMR1 = 020 | reg;
adr = ReadW (adr | ds); adr = ReadW (adr | ds);
return (adr | dsenable); return (adr | dsenable);
case 4: /* -(R) */ case 4: /* -(R) */
adr = R[reg] = (R[reg] - len) & 0177777; adr = R[reg] = (R[reg] - len) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = (((-len) & 037) << 3) | reg; MMR1 = (((-len) & 037) << 3) | reg;
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);
@ -605,7 +606,7 @@ switch (spec >> 3) { /* case on spec */
case 5: /* @-(R) */ case 5: /* @-(R) */
adr = R[reg] = (R[reg] - 2) & 0177777; adr = R[reg] = (R[reg] - 2) & 0177777;
if (update_MM) if (update_MM && (reg != 7))
MMR1 = 0360 | reg; MMR1 = 0360 | reg;
if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y))) if ((reg == 6) && (cm == MD_KER) && (adr < (STKLIM + STKL_Y)))
set_stack_trap (adr); set_stack_trap (adr);