folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TIMER: Be sure to empty the event queue at timer initialization

Browse source 
If a reset_all_p() happens before the timing subsystem is initialized,
events can be queued with unreasonable timing measurements.
This commit is contained in:
Mark Pizzolato 2020-03-07 07:05:46 -08:00
parent e6d8d593b4
commit 42bb47d961
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sim_timer.c
View file

@ -1124,12 +1124,18 @@ int tmr;
uint32 clock_start, clock_last, clock_now; uint32 clock_start, clock_last, clock_now;
sim_debug (DBG_TRC, &sim_timer_dev, "sim_timer_init()\n"); sim_debug (DBG_TRC, &sim_timer_dev, "sim_timer_init()\n");
/* Clear the event queue before initializing the timer subsystem */
while (sim_clock_queue != QUEUE_LIST_END)
sim_cancel (sim_clock_queue);
for (tmr=0; tmr<=SIM_NTIMERS; tmr++) { for (tmr=0; tmr<=SIM_NTIMERS; tmr++) {
RTC *rtc = &rtcs[tmr]; RTC *rtc = &rtcs[tmr];
rtc->timer_unit = &sim_timer_units[tmr]; rtc->timer_unit = &sim_timer_units[tmr];
rtc->timer_unit->action = &sim_timer_tick_svc; rtc->timer_unit->action = &sim_timer_tick_svc;
rtc->timer_unit->flags = UNIT_DIS | UNIT_IDLE; rtc->timer_unit->flags = UNIT_DIS | UNIT_IDLE;
if (rtc->clock_cosched_queue)
while (rtc->clock_cosched_queue != QUEUE_LIST_END)
sim_cancel (rtc->clock_cosched_queue);
rtc->clock_cosched_queue = QUEUE_LIST_END; rtc->clock_cosched_queue = QUEUE_LIST_END;
} }
sim_stop_unit.action = &sim_timer_stop_svc; sim_stop_unit.action = &sim_timer_stop_svc;