folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

H316: Use snprintf() to avoid potential buffer overflow

Browse source
This commit is contained in:
Mark Pizzolato 2019-07-16 04:12:42 -07:00
parent 6041cd627b
commit 437e5a4bb5
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
H316/h316_udp.c
View file

@ -223,23 +223,23 @@ t_stat udp_parse_remote (int32 link, const char *premote)
// Handle the llll::rrrr case first
if (2 == sscanf (premote, "%d::%d", &lport, &rport)) {
if ((lport < 1) || (lport >65535) || (rport < 1) || (rport >65535)) return SCPE_ARG;
sprintf (udp_links[link].lport, "%d", lport);
sprintf (udp_links[link].rhostport, "localhost:%d", rport);
snprintf (udp_links[link].lport, sizeof (udp_links[link].lport) - 1, "%d", lport);
snprintf (udp_links[link].rhostport, sizeof (udp_links[link].rhostport) - 1, "localhost:%d", rport);
return SCPE_OK;
}
// Look for the local port number and save it away.
lport = strtoul(premote, &end, 10);
if ((*end == ':') && (lport > 0)) {
sprintf (udp_links[link].lport, "%d", lport);
snprintf (udp_links[link].lport, sizeof (udp_links[link].lport) - 1, "%d", lport);
premote = end+1;
}
if (sim_parse_addr (premote, host, sizeof(host), "localhost", port, sizeof(port), NULL, NULL))
return SCPE_ARG;
sprintf (udp_links[link].rhostport, "%s:%s", host, port);
snprintf (udp_links[link].rhostport, sizeof (udp_links[link].rhostport) - 1, "%s:%s", host, port);
if (udp_links[link].lport[0] == '\0')
strcpy (udp_links[link].lport, port);
strlcpy (udp_links[link].lport, port, sizeof (udp_links[link].lport));
if ((strcmp (udp_links[link].lport, port) == 0) &&
(strcmp ("localhost", host) == 0))