From 46133b5dd8c8f88464769bf31bb67ae53ec59470 Mon Sep 17 00:00:00 2001 From: Mark Pizzolato Date: Mon, 19 Oct 2020 12:31:02 -0700 Subject: [PATCH] PDP18B: Compiler warning cleanup - Remove unused variable assignment - Avoid potential out of array indexing due to theoretical array reference via signed char index. Likely non functional change. --- PDP18B/pdp18b_dr15.c | 2 -- PDP18B/pdp18b_lp.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/PDP18B/pdp18b_dr15.c b/PDP18B/pdp18b_dr15.c index d00d8407..934ed1e6 100644 --- a/PDP18B/pdp18b_dr15.c +++ b/PDP18B/pdp18b_dr15.c @@ -141,8 +141,6 @@ DEVICE dr15_dev = { int32 dr60 (int32 dev, int32 pulse, int32 AC) { -int32 subdev = (pulse >> 4) & 03; - if (((pulse & 01) != 0) && (dr15_tcb_ack != 0)) /* SIOA */ AC |= IOT_SKP; if ((pulse & 02) != 0) /* CIOP */ diff --git a/PDP18B/pdp18b_lp.c b/PDP18B/pdp18b_lp.c index 58852ff8..0db2ec41 100644 --- a/PDP18B/pdp18b_lp.c +++ b/PDP18B/pdp18b_lp.c @@ -834,10 +834,10 @@ for (more = 1; more != 0; ) { /* loop until ctrl */ ccnt = 5; } for (i = 0; i < ccnt; i++) { /* loop through */ - if ((c[i] <= 037) && ctrl[c[i]]) { /* control char? */ + if ((c[i] <= 037) && ctrl[c[i] & 037]) { /* control char? */ lp15_buf[lp15_bp] = 0; /* append nul */ fputs (lp15_buf, uptr->fileref); /* print line */ - fputs (ctrl[c[i]], uptr->fileref); /* space */ + fputs (ctrl[c[i] & 037], uptr->fileref); /* space */ uptr->pos = ftell (uptr->fileref); if (ferror (uptr->fileref)) { /* error? */ sim_perror ("LPT I/O error");