folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SWTP6800: Fix Coverity issue

Browse source
This commit is contained in:
Mark Pizzolato 2022-03-12 07:58:04 -08:00
parent 8ae7d4fbcd
commit 56688be951
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
swtp6800/common/bootrom.c
View file

@ -131,20 +131,21 @@ DEVICE BOOTROM_dev = {
t_stat BOOTROM_attach (UNIT *uptr, CONST char *cptr) t_stat BOOTROM_attach (UNIT *uptr, CONST char *cptr)
{ {
t_stat r; t_stat r;
t_addr image_size, capac; t_offset image_size;
t_addr capac;
int i; int i;
sim_debug (DEBUG_flow, &BOOTROM_dev, "BOOTROM_attach: cptr=%s\n", cptr); sim_debug (DEBUG_flow, &BOOTROM_dev, "BOOTROM_attach: cptr=%s\n", cptr);
if ((r = attach_unit (uptr, cptr)) != SCPE_OK) { if ((r = attach_unit (uptr, cptr)) != SCPE_OK) {
sim_debug (DEBUG_flow, &BOOTROM_dev, "BOOTROM_attach: Error\n"); sim_debug (DEBUG_flow, &BOOTROM_dev, "BOOTROM_attach: Error\n");
return r; return sim_messagef (r, "BOOTROM_attach: Failure\n");
} }
image_size = (t_addr)sim_fsize_ex (BOOTROM_unit.fileref); image_size = (t_addr)sim_fsize_ex (BOOTROM_unit.fileref);
if (image_size <= 0) { if (image_size <= 0) {
sim_printf("BOOTROM_attach: File error\n"); detach_unit (uptr);
return SCPE_IOERR; return sim_messagef(SCPE_IOERR,"BOOTROM_attach: File empty\n");
} }
for (capac = 0x200, i=1; capac < image_size; capac <<= 1, i++); for (capac = 0x200, i=1; capac < (t_addr)image_size; capac <<= 1, i++);
if (i > (UNIT_2764>>UNIT_V_MSIZE)) { if (i > (UNIT_2764>>UNIT_V_MSIZE)) {
detach_unit (uptr); detach_unit (uptr);
return SCPE_ARG; return SCPE_ARG;