folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PDP10: Documented switch fall through case (COVERITY)

Browse source
This commit is contained in:
Bob Supnik 2017-03-28 14:32:10 -07:00 • committed by Mark Pizzolato
parent 3989251f85
commit 5896b1c20d
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
PDP10/pdp10_tu.c
View file

@ -1,6 +1,6 @@
/* pdp10_tu.c - PDP-10 RH11/TM03/TU45 magnetic tape simulator /* pdp10_tu.c - PDP-10 RH11/TM03/TU45 magnetic tape simulator
Copyright (c) 1993-2008, Robert M Supnik Copyright (c) 1993-2017, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"), copy of this software and associated documentation files (the "Software"),
@ -25,7 +25,9 @@
tu RH11/TM03/TU45 magtape tu RH11/TM03/TU45 magtape
29-Apr-07 RMS Fixed bug in setting FCE on TMK (found by Naoki Hamada) 28-Mar-17 RMS Documented switch fall through case (COVERITY)
17-Mar-13 RMS Fixed bug in read/write check reverse (Dave Bryan)
29-Apr-07 RMS Fixed bug in setting FCE on TMK (Naoki Hamada)
16-Feb-06 RMS Added tape capacity checking 16-Feb-06 RMS Added tape capacity checking
16-Aug-05 RMS Fixed C++ declaration and cast problems 16-Aug-05 RMS Fixed C++ declaration and cast problems
07-Jul-05 RMS Removed extraneous externs 07-Jul-05 RMS Removed extraneous externs
@ -669,6 +671,7 @@ switch (fnc) { /* case on function */
if (!(uptr->TU_STATEFLAGS & TUS_ATTPENDING)) if (!(uptr->TU_STATEFLAGS & TUS_ATTPENDING))
sim_cancel (uptr); /* stop motion, not on-line delay */ sim_cancel (uptr); /* stop motion, not on-line delay */
uptr->USTAT = 0; uptr->USTAT = 0;
/* fall through */
case FNC_NOP: case FNC_NOP:
tucs1 = tucs1 & ~CS1_GO; /* no operation */ tucs1 = tucs1 & ~CS1_GO; /* no operation */
return; return;
@ -1162,9 +1165,10 @@ for (u = 0; u < TU_NUMDR; u++) { /* loop thru units */
sim_tape_reset (uptr); /* clear pos flag */ sim_tape_reset (uptr); /* clear pos flag */
if (!uptr->TU_STATEFLAGS & TUS_ATTPENDING) /* Delayed on-line must survive massbus clear */ if (!uptr->TU_STATEFLAGS & TUS_ATTPENDING) /* Delayed on-line must survive massbus clear */
sim_cancel (uptr); /* cancel activity */ sim_cancel (uptr); /* cancel activity */
else if (!sim_is_active(uptr) ) else {
if (!sim_is_active(uptr) )
sim_activate_after(uptr, SPINUPDLY); sim_activate_after(uptr, SPINUPDLY);
}
uptr->USTAT = 0; uptr->USTAT = 0;
} }
if (xbuf == NULL) if (xbuf == NULL)