folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

FRONTPANEL: Fix Coverity identified issues

Browse source
This commit is contained in:
Mark Pizzolato 2017-03-18 02:17:35 -07:00
parent 0f41c24cb8
commit 5fb61c83e3
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sim_frontpanel.c
View file

@ -1943,9 +1943,9 @@ while ((p->sock != INVALID_SOCKET) &&
data = strtoull (e, NULL, 16); data = strtoull (e, NULL, 16);
if (little_endian) if (little_endian)
memcpy (p->regs[i].addr, &data, p->regs[i].size); memcpy (r->addr, &data, r->size);
else else
memcpy (p->regs[i].addr, ((char *)&data) + sizeof(data)-p->regs[i].size, p->regs[i].size); memcpy (r->addr, ((char *)&data) + sizeof(data)-r->size, r->size);
r = NULL; r = NULL;
} }
s = eol; s = eol;
@ -2138,7 +2138,8 @@ while ((p->sock != INVALID_SOCKET) &&
for (c = strchr (repeat, '\r'); c != NULL; c = strchr (c, '\r')) for (c = strchr (repeat, '\r'); c != NULL; c = strchr (c, '\r'))
*c = ';'; /* replace carriage returns with semicolons */ *c = ';'; /* replace carriage returns with semicolons */
c = strstr (repeat, register_get_echo); /* remove register_done_echo string and */ c = strstr (repeat, register_get_echo); /* remove register_done_echo string and */
strcpy (c, register_repeat_echo); /* replace it with the register_repeat_echo string */ if (c) /* always true */
strcpy (c, register_repeat_echo); /* replace it with the register_repeat_echo string */
if (_panel_sendf (p, &cmd_stat, NULL, "%s", repeat)) { if (_panel_sendf (p, &cmd_stat, NULL, "%s", repeat)) {
pthread_mutex_lock (&p->io_lock); pthread_mutex_lock (&p->io_lock);
free (repeat); free (repeat);