folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALTAIR: Fix potential reference to uninitialized memory (Coverity)

Browse source
This commit is contained in:
Mark Pizzolato 2017-03-29 07:04:29 -07:00
parent fa7e350c78
commit 62dc8ff6ec
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ALTAIR/altair_sys.c
View file

@ -234,6 +234,7 @@ t_stat parse_sym (CONST char *cptr, t_addr addr, UNIT *uptr, t_value *val, int32
int32 cflag, i = 0, j, r; int32 cflag, i = 0, j, r;
char gbuf[CBUFSIZE]; char gbuf[CBUFSIZE];
memset (gbuf, 0, sizeof (gbuf));
cflag = (uptr == NULL) || (uptr == &cpu_unit); cflag = (uptr == NULL) || (uptr == &cpu_unit);
while (isspace (*cptr)) cptr++; /* absorb spaces */ while (isspace (*cptr)) cptr++; /* absorb spaces */
if ((sw & SWMASK ('A')) || ((*cptr == '\'') && cptr++)) { /* ASCII char? */ if ((sw & SWMASK ('A')) || ((*cptr == '\'') && cptr++)) { /* ASCII char? */
@ -251,7 +252,7 @@ if ((sw & SWMASK ('C')) || ((*cptr == '"') && cptr++)) { /* ASCII string? */
or numeric (including spaces). or numeric (including spaces).
*/ */
while (1) { while (i < sizeof (gbuf)) {
if (*cptr == ',' || *cptr == '\0' || if (*cptr == ',' || *cptr == '\0' ||
isdigit(*cptr)) isdigit(*cptr))
break; break;
@ -285,9 +286,7 @@ if (toupper(gbuf[0]) == 'M' &&
/* kill trailing spaces if any */ /* kill trailing spaces if any */
gbuf[i] = '\0'; gbuf[i] = '\0';
for (j = i - 1; gbuf[j] == ' '; j--) { sim_trim_endspc (gbuf);
gbuf[j] = '\0';
}
/* find opcode in table */ /* find opcode in table */
for (j = 0; j < 256; j++) { for (j = 0; j < 256; j++) {