folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

All VAX: Fixed certain indirect cases in parse (COVERITY)

Browse source
This commit is contained in:
Bob Supnik 2017-03-14 04:32:50 -07:00 • committed by Mark Pizzolato
parent f52b5346fa
commit 71479d6c0b
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
VAX/vax_sys.c
View file

@ -24,6 +24,7 @@
in this Software without prior written authorization from Robert M Supnik. in this Software without prior written authorization from Robert M Supnik.
13-Mar-17 RMS Annotated intentional fall throughs in switch 13-Mar-17 RMS Annotated intentional fall throughs in switch
Fixed certain indirect cases in parse (COVERITY)
21-Mar-11 RMS Modified string for STOP_BOOT message 21-Mar-11 RMS Modified string for STOP_BOOT message
19-Nov-08 RMS Moved bad block routine to I/O library 19-Nov-08 RMS Moved bad block routine to I/O library
03-Nov-05 RMS Added 780 stop codes 03-Nov-05 RMS Added 780 stop codes
@ -1384,7 +1385,7 @@ switch (fl) { /* case on state */
dispsize = 4; dispsize = 4;
} }
} }
val[vp++] = mode | nPC | ((fl & SP_IND)? 1: 0); val[vp++] = mode | nPC | ((fl & SP_IND)? 0x10: 0);
PUTNUM (num, dispsize); PUTNUM (num, dispsize);
break; break;
@ -1393,7 +1394,7 @@ switch (fl) { /* case on state */
num = lit[0] - (addr + vp + 2); num = lit[0] - (addr + vp + 2);
if ((litsize > 0) || (num > 127) || (num < -128)) if ((litsize > 0) || (num > 127) || (num < -128))
PARSE_LOSE; PARSE_LOSE;
val[vp++] = nPC | BDP | ((fl & SP_IND)? 1: 0); val[vp++] = nPC | BDP | ((fl & SP_IND)? 0x10: 0);
PUTNUM (num, 1); PUTNUM (num, 1);
break; break;
@ -1402,7 +1403,7 @@ switch (fl) { /* case on state */
num = lit[0] - (addr + vp + 3); num = lit[0] - (addr + vp + 3);
if ((litsize > 0) || (num > 32767) || (num < -32768)) if ((litsize > 0) || (num > 32767) || (num < -32768))
PARSE_LOSE; PARSE_LOSE;
val[vp++] = nPC | WDP | ((fl & SP_IND)? 1: 0); val[vp++] = nPC | WDP | ((fl & SP_IND)? 0x10: 0);
PUTNUM (num, 2); PUTNUM (num, 2);
break; break;
@ -1411,7 +1412,7 @@ switch (fl) { /* case on state */
num = lit[0] - (addr + vp + 5); num = lit[0] - (addr + vp + 5);
if (litsize > 0) if (litsize > 0)
PARSE_LOSE; PARSE_LOSE;
val[vp++] = nPC | LDP | ((fl & SP_IND)? 1: 0); val[vp++] = nPC | LDP | ((fl & SP_IND)? 0x10: 0);
PUTNUM (num, 4); PUTNUM (num, 4);
break; break;