From 7c1c04d9a9bda0cc2f3e1c3c399b942d5ac94b12 Mon Sep 17 00:00:00 2001
From: Mark Pizzolato <mark@infocomm.com>
Date: Thu, 14 Nov 2019 21:38:45 -0800
Subject: [PATCH] SCP: Clear Coverity identified warnings

---
 scp.c        | 3 ++-
 sim_serial.c | 2 +-
 sim_tape.c   | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/scp.c b/scp.c
index 3a7c098c..4ad1aa09 100644
--- a/scp.c
+++ b/scp.c
@@ -2865,7 +2865,8 @@ fprintf (st, "   HELP dev SET\n");
 fprintf (st, "   HELP dev SHOW\n");
 fprintf (st, "   HELP dev REGISTERS\n\n");
 fprintf (st, "Help is available for the following commands:\n\n    ");
-qsort (hlp_cmdp, cmd_cnt, sizeof(*hlp_cmdp), _cmd_name_compare);
+if (hlp_cmdp)
+    qsort (hlp_cmdp, cmd_cnt, sizeof(*hlp_cmdp), _cmd_name_compare);
 line_offset = 4;
 for (i=0; i<cmd_cnt; ++i) {
     fputs (hlp_cmdp[i]->name, st);
diff --git a/sim_serial.c b/sim_serial.c
index dc13960b..86ae870e 100644
--- a/sim_serial.c
+++ b/sim_serial.c
@@ -448,8 +448,8 @@ return port;
 
 void sim_close_serial (SERHANDLE port)
 {
-sim_close_os_serial (port);
 _serial_remove_from_open_list (port);
+sim_close_os_serial (port);
 }
 
 t_stat sim_config_serial  (SERHANDLE port, CONST char *sconfig)
diff --git a/sim_tape.c b/sim_tape.c
index 8729a897..f16c8259 100644
--- a/sim_tape.c
+++ b/sim_tape.c
@@ -4232,7 +4232,7 @@ static void ansi_fill_text_buffer (FILE *f, char *buf, size_t buf_size, size_t r
             if (rec_size >= record_skip_ending)
                 rec_size -= record_skip_ending;
             if ((rec_size + 4) > (int)(buf_size - offset)) { /* room for record? */
-                fseek (f, start, SEEK_SET);
+                (void)fseek (f, start, SEEK_SET);
                 break;
                 }
             sprintf (rec_size_str, "%04u", (int)(rec_size + 4));