folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NOVA: Fix carry display in CPU instruction history

Browse source 
Problem: Currently when viewing the Nova CPU history the carry flag is always
displayed as 0 regardless of it's actual value at the time.

Cause: The carry bit is stored in bit 17 and is lost when stored into the
int16 carry member of struct Hist_entry

Solution: Shift carry into bit 0 before storing it in the CPU history.
Improve code for displaying carry bit.
This commit is contained in:
Samuel Deutsch 2020-09-26 17:57:17 -04:00
parent d8004ccaf6
commit 83d35a26aa
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
NOVA/nova_cpu.c
View file

@ -1316,7 +1316,7 @@ if ( hist )
hist_ptr->ac1 = AC[ 1 ] ; hist_ptr->ac1 = AC[ 1 ] ;
hist_ptr->ac2 = AC[ 2 ] ; hist_ptr->ac2 = AC[ 2 ] ;
hist_ptr->ac3 = AC[ 3 ] ; hist_ptr->ac3 = AC[ 3 ] ;
hist_ptr->carry = C ; hist_ptr->carry = C >> 16 ;
hist_ptr->fp = FP ; hist_ptr->fp = FP ;
hist_ptr->sp = SP ; hist_ptr->sp = SP ;
hist_ptr->devBusy = dev_busy ; hist_ptr->devBusy = dev_busy ;
@ -1386,7 +1386,7 @@ if ( hptr )
(hptr->ac1 & 0xFFFF), (hptr->ac1 & 0xFFFF),
(hptr->ac2 & 0xFFFF), (hptr->ac2 & 0xFFFF),
(hptr->ac3 & 0xFFFF), (hptr->ac3 & 0xFFFF),
((hptr->carry) ? 1 : 0) (hptr->carry & 1)
) ; ) ;
if ( cpu_unit.flags & UNIT_STK /* Nova 3 or Nova 4 */ ) if ( cpu_unit.flags & UNIT_STK /* Nova 3 or Nova 4 */ )
{ {