folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

H316: Remove Coverity indicated warnings rather than declaring them intentional

Browse source
This commit is contained in:
Mark Pizzolato 2019-07-07 19:29:30 -07:00
parent 526e03bbe1
commit 85770281fb
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
H316/h316_cpu.c
View file

@ -402,7 +402,7 @@ DEVICE cpu_dev = {
t_stat sim_instr (void) t_stat sim_instr (void)
{ {
int32 AR, BR, MB, Y, t1, t2, t3, skip, dev; int32 AR, BR, MB, Y = 0, t1, t2, t3, skip, dev;
uint32 ut; uint32 ut;
t_bool iack; // [RLA] TRUE if an interrupt was taken this cycle t_bool iack; // [RLA] TRUE if an interrupt was taken this cycle
t_stat reason; t_stat reason;

4
H316/h316_dp.c
View file

@ -790,7 +790,7 @@ t_stat dp_rdtrk (UNIT *uptr, uint16 *buf, uint32 c, uint32 h)
uint32 da = ((c * dp_tab[dp_ctype].surf) + h) * DP_TRKLEN; uint32 da = ((c * dp_tab[dp_ctype].surf) + h) * DP_TRKLEN;
int32 l; int32 l;
fseek (uptr->fileref, da * sizeof (uint16), SEEK_SET); (void)fseek (uptr->fileref, da * sizeof (uint16), SEEK_SET);
l = fxread (buf, sizeof (uint16), DP_TRKLEN, uptr->fileref); l = fxread (buf, sizeof (uint16), DP_TRKLEN, uptr->fileref);
for ( ; l < DP_TRKLEN; l++) for ( ; l < DP_TRKLEN; l++)
buf[l] = 0; buf[l] = 0;
@ -809,7 +809,7 @@ t_stat dp_wrtrk (UNIT *uptr, uint16 *buf, uint32 c, uint32 h)
{ {
uint32 da = ((c * dp_tab[dp_ctype].surf) + h) * DP_TRKLEN; uint32 da = ((c * dp_tab[dp_ctype].surf) + h) * DP_TRKLEN;
fseek (uptr->fileref, da * sizeof (uint16), SEEK_SET); (void)fseek (uptr->fileref, da * sizeof (uint16), SEEK_SET);
fxwrite (buf, sizeof (uint16), DP_TRKLEN, uptr->fileref); fxwrite (buf, sizeof (uint16), DP_TRKLEN, uptr->fileref);
if (ferror (uptr->fileref)) { if (ferror (uptr->fileref)) {
sim_perror ("DP I/O error"); sim_perror ("DP I/O error");

6
H316/h316_udp.c
View file

@ -286,9 +286,9 @@ t_stat udp_create (DEVICE *dptr, const char *premote, int32 *pln)
udp_links[link].used = TRUE; *pln = link; udp_links[link].used = TRUE; *pln = link;
udp_lines[link].dptr = udp_links[link].dptr = dptr; // save device udp_lines[link].dptr = udp_links[link].dptr = dptr; // save device
udp_tmxr.uptr = dptr->units; udp_tmxr.uptr = dptr->units;
udp_tmxr.last_poll_time = 1; // h316'a use of TMXR doesn't poll periodically for connects udp_tmxr.last_poll_time = 1; // h316's use of TMXR doesn't poll periodically for connects
tmxr_poll_conn (&udp_tmxr); // force connection initialization now (void)tmxr_poll_conn (&udp_tmxr); // force connection initialization now
udp_tmxr.last_poll_time = 1; // h316'a use of TMXR doesn't poll periodically for connects udp_tmxr.last_poll_time = 1; // h316's use of TMXR doesn't poll periodically for connects
sim_debug(IMP_DBG_UDP, dptr, "link %d - listening on port %s and sending to %s\n", link, udp_links[link].lport, udp_links[link].rhostport); sim_debug(IMP_DBG_UDP, dptr, "link %d - listening on port %s and sending to %s\n", link, udp_links[link].lport, udp_links[link].rhostport);
return SCPE_OK; return SCPE_OK;
} }