From 880c8a89b7c06a8afc8fa8c50146c7a0bee48c9c Mon Sep 17 00:00:00 2001
From: Mark Pizzolato <mark@infocomm.com>
Date: Wed, 20 Feb 2019 08:32:37 -0800
Subject: [PATCH] PDP11, PDP18b, PDP8, VAX750, SCP: Silence Coverity identified
 complaints

---
 PDP1/pdp1_dt.c     | 2 +-
 PDP11/pdp11_ch.c   | 4 ++--
 PDP18B/pdp18b_dt.c | 2 +-
 PDP8/pdp8_dt.c     | 2 +-
 VAX/vax750_mem.c   | 2 +-
 sim_console.c      | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/PDP1/pdp1_dt.c b/PDP1/pdp1_dt.c
index 6c10f030..856c2393 100644
--- a/PDP1/pdp1_dt.c
+++ b/PDP1/pdp1_dt.c
@@ -646,7 +646,7 @@ t_bool dt_setpos (UNIT *uptr)
 {
 uint32 new_time, ut, ulin, udelt;
 int32 mot = DTS_GETMOT (uptr->STATE);
-int32 unum, delta;
+int32 unum, delta = 0;
 
 new_time = sim_grtime ();                               /* current time */
 ut = new_time - uptr->LASTT;                            /* elapsed time */
diff --git a/PDP11/pdp11_ch.c b/PDP11/pdp11_ch.c
index 586b124d..85de27f8 100644
--- a/PDP11/pdp11_ch.c
+++ b/PDP11/pdp11_ch.c
@@ -403,7 +403,7 @@ t_stat ch_wr (int32 data, int32 PA, int32 access)
 t_stat ch_svc(UNIT *uptr)
 {
   sim_clock_coschedule (uptr, 1000);
-  tmxr_poll_conn (&ch_tmxr);
+  (void)tmxr_poll_conn (&ch_tmxr);
   if (ch_lines[0].conn)
     ch_receive ();
   return SCPE_OK;
@@ -474,7 +474,7 @@ t_stat ch_set_peer (UNIT* uptr, int32 val, CONST char* cptr, void* desc)
   if (host[0] == '\0')
     return SCPE_ARG;
 
-  strncpy (peer, cptr, sizeof peer);
+  strlcpy (peer, cptr, sizeof peer);
   return SCPE_OK;
 }
 
diff --git a/PDP18B/pdp18b_dt.c b/PDP18B/pdp18b_dt.c
index bbdcde57..4b42a0ec 100644
--- a/PDP18B/pdp18b_dt.c
+++ b/PDP18B/pdp18b_dt.c
@@ -832,7 +832,7 @@ t_bool dt_setpos (UNIT *uptr)
 {
 uint32 new_time, ut, ulin, udelt;
 int32 mot = DTS_GETMOT (uptr->STATE);
-int32 unum, delta;
+int32 unum, delta = 0;
 
 new_time = sim_grtime ();                               /* current time */
 ut = new_time - uptr->LASTT;                            /* elapsed time */
diff --git a/PDP8/pdp8_dt.c b/PDP8/pdp8_dt.c
index 2e29f394..7ac2330a 100644
--- a/PDP8/pdp8_dt.c
+++ b/PDP8/pdp8_dt.c
@@ -649,7 +649,7 @@ t_bool dt_setpos (UNIT *uptr)
 {
 uint32 new_time, ut, ulin, udelt;
 int32 mot = DTS_GETMOT (uptr->STATE);
-int32 unum, delta;
+int32 unum, delta = 0;
 
 new_time = sim_grtime ();                               /* current time */
 ut = new_time - uptr->LASTT;                            /* elapsed time */
diff --git a/VAX/vax750_mem.c b/VAX/vax750_mem.c
index ec0e9f43..7d13c4cf 100644
--- a/VAX/vax750_mem.c
+++ b/VAX/vax750_mem.c
@@ -268,7 +268,7 @@ struct {
         { 1024, "MS750-CA M8750"},
         {  256, "MS750-AA M8728"}, 
         {    0, NULL}};
-int32 i, bd;
+int32 i, bd = 0;
 
 for (i=0; i<8; i++) {
     if (mcsr2&MCSR2_CS256) {
diff --git a/sim_console.c b/sim_console.c
index 2b7322af..9bbbad0b 100644
--- a/sim_console.c
+++ b/sim_console.c
@@ -667,7 +667,7 @@ if (c >= 0) {                                           /* poll connect */
     TMLN *lp = rem->lp;
     char wru_name[8];
 
-    sim_activate_after(uptr+1, 1000000);                /* start data poll after 1 second */
+    sim_activate_after(rem_con_data_unit, 1000000);     /* start data poll after 1 second */
     lp->rcve = 1;                                       /* rcv enabled */
     rem->buf_ptr = 0;                                   /* start with empty command buffer */
     rem->single_mode = TRUE;                            /* start in single command mode */