folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

I7094: Annotated fall through in switch (COVERITY)

Browse source
This commit is contained in:
Bob Supnik 2017-03-20 07:46:28 -07:00 • committed by Mark Pizzolato
parent a040eb4e32
commit a37e9284e1
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
I7094/i7094_dsk.c
View file

@ -119,7 +119,7 @@
#define SIZE_2302 (DSK_WDSPT_2302*DSK_TRKPA_2302*DSK_ACCPM_2302) #define SIZE_2302 (DSK_WDSPT_2302*DSK_TRKPA_2302*DSK_ACCPM_2302)
#define DSK_BUFSIZ (DSK_WDSPT_2302) #define DSK_BUFSIZ (DSK_WDSPT_2302)
#define DSK_DA(a,t,d) (((((a) * dsk_tab[d].trkpa) + (t)) * dsk_tab[d].wdspt) *\ #define DSK_DA(a,t,d) (((((a) * dsk_tab[d].trkpa) + (t)) * dsk_tab[d].wdspt) *\
sizeof (t_uint64)) sizeof (t_uint64))
/* Unit flags */ /* Unit flags */

7
I7094/i7094_io.c
View file

@ -1,6 +1,6 @@
/* i7094_io.c: IBM 7094 I/O subsystem (channels) /* i7094_io.c: IBM 7094 I/O subsystem (channels)
Copyright (c) 2003-2012, Robert M. Supnik Copyright (c) 2003-2017, Robert M. Supnik
Permission is hereby granted, free of charge, to any person obtaining a Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"), copy of this software and associated documentation files (the "Software"),
@ -25,6 +25,7 @@
chana..chanh I/O channels chana..chanh I/O channels
13-Mar-17 RMS Annotated fall through in switch
19-Mar-12 RMS Fixed declaration of breakpoint variables (Mark Pizzolato) 19-Mar-12 RMS Fixed declaration of breakpoint variables (Mark Pizzolato)
Notes on channels and CTSS. Notes on channels and CTSS.
@ -1301,6 +1302,7 @@ switch (op) { /* case on opcode */
case CH6_IOST: /* IOST */ case CH6_IOST: /* IOST */
if (ch_flags[ch] & CHF_EOR) /* EOR set? immed ch req */ if (ch_flags[ch] & CHF_EOR) /* EOR set? immed ch req */
ch_req |= REQ_CH (ch); ch_req |= REQ_CH (ch);
/* fall through */
case CH6_IOCT: /* IOCT */ case CH6_IOCT: /* IOCT */
if (ch_wc[ch] == 0) { /* wc 0? */ if (ch_wc[ch] == 0) { /* wc 0? */
if (ch_ld) /* load? end now */ if (ch_ld) /* load? end now */
@ -1312,6 +1314,7 @@ switch (op) { /* case on opcode */
case CH6_IOSP: /* IOSP */ case CH6_IOSP: /* IOSP */
if (ch_flags[ch] & CHF_EOR) /* EOR set? immed ch req */ if (ch_flags[ch] & CHF_EOR) /* EOR set? immed ch req */
ch_req |= REQ_CH (ch); ch_req |= REQ_CH (ch);
/* fall through */
case CH6_IOCP: /* IOCP */ case CH6_IOCP: /* IOCP */
if (ch_wc[ch] == 0) /* wc 0? immed ch req */ if (ch_wc[ch] == 0) /* wc 0? immed ch req */
ch_req |= REQ_CH (ch); ch_req |= REQ_CH (ch);
@ -1539,7 +1542,7 @@ switch (ch_op[ch]) { /* check initial cond */
case CH9_SMS: case CH9_SMS:
if (ch_flags[ch] & (CHF_PRD|CHF_PWR|CHF_RDS|CHF_WRS)) if (ch_flags[ch] & (CHF_PRD|CHF_PWR|CHF_RDS|CHF_WRS))
ch9_eval_int (ch, CHINT_SEQC); /* not during data */ ch9_eval_int (ch, CHINT_SEQC); /* not during data */
/* fall through */ /* fall through */
case CH9_TCM: /* jumps */ case CH9_TCM: /* jumps */
case CH9_TCH: case CH9_TCH:
case CH9_TDC: case CH9_TDC: