folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

VAX: fix CID: 1415411, 1415414-1415417, 1415535 "Buffer not null terminated"

Browse source 
Pass buffer size minus one to strncpy()
This commit is contained in:
Sergey Svishchev 2017-03-09 17:20:54 -08:00 • committed by Mark Pizzolato
parent 2e2df8fc2d
commit b40e63de4e
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
VAX/vax610_sysdev.c
View file

@ -371,7 +371,7 @@ if (r != SCPE_OK) { /* error? */
} }
return r; return r;
} }
strncpy (cpu_boot_cmd, ptr, CBUFSIZE); /* save for reboot */ strncpy (cpu_boot_cmd, ptr, CBUFSIZE-1); /* save for reboot */
return run_cmd (flag, "CPU"); return run_cmd (flag, "CPU");
} }

2
VAX/vax730_sys.c
View file

@ -478,7 +478,7 @@ if (r != SCPE_OK) { /* error? */
} }
return r; return r;
} }
strncpy (cpu_boot_cmd, ptr, CBUFSIZE); /* save for reboot */ strncpy (cpu_boot_cmd, ptr, CBUFSIZE-1); /* save for reboot */
return run_cmd (flag, "CPU"); return run_cmd (flag, "CPU");
} }

2
VAX/vax750_cmi.c
View file

@ -617,7 +617,7 @@ if (r != SCPE_OK) { /* error? */
} }
return r; return r;
} }
strncpy (cpu_boot_cmd, ptr, CBUFSIZE); /* save for reboot */ strncpy (cpu_boot_cmd, ptr, CBUFSIZE-1); /* save for reboot */
return run_cmd (flag, "CPU"); return run_cmd (flag, "CPU");
} }

2
VAX/vax780_sbi.c
View file

@ -630,7 +630,7 @@ if (r != SCPE_OK) { /* error? */
} }
return r; return r;
} }
strncpy (cpu_boot_cmd, ptr, CBUFSIZE); /* save for reboot */ strncpy (cpu_boot_cmd, ptr, CBUFSIZE-1); /* save for reboot */
return run_cmd (flag, "CPU"); return run_cmd (flag, "CPU");
} }

2
VAX/vax860_abus.c
View file

@ -693,7 +693,7 @@ if (r != SCPE_OK) { /* error? */
} }
return r; return r;
} }
strncpy (cpu_boot_cmd, ptr, CBUFSIZE); /* save for reboot */ strncpy (cpu_boot_cmd, ptr, CBUFSIZE-1); /* save for reboot */
return run_cmd (flag, "CPU"); return run_cmd (flag, "CPU");
} }