From ddb4cb46613058fd8af91f0183bcfd0e0b535309 Mon Sep 17 00:00:00 2001 From: Peter Schorn Date: Sun, 24 Mar 2019 21:51:26 +0100 Subject: [PATCH] AltairZ80: Fix issue detected by Coverity (unchecked sim_fseek in n8vem.c) --- AltairZ80/n8vem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/AltairZ80/n8vem.c b/AltairZ80/n8vem.c index 25030aff..eee85707 100644 --- a/AltairZ80/n8vem.c +++ b/AltairZ80/n8vem.c @@ -279,9 +279,9 @@ static t_stat n8vem_detach(UNIT *uptr) sim_debug(VERBOSE_MSG, &n8vem_dev, "N8VEM: Detach %s.\n", i == 0 ? "ROM" : "RAM"); /* rewind to the beginning of the file. */ - sim_fseek(uptr->fileref, 0, SEEK_SET); - - if(i == 0) { /* ROM */ + if(sim_fseek(uptr->fileref, 0, SEEK_SET)) { + sim_debug(VERBOSE_MSG, &n8vem_dev, "N8VEM: Cannot write into %s image.\n", i == 0 ? "ROM" : "RAM"); + } else if(i == 0) { /* ROM */ /* Save the ROM back to disk if SAVEROM is set. */ if(save_rom == 1) { sim_debug(VERBOSE_MSG, &n8vem_dev, "N8VEM: Writing %d bytes into ROM image.\n", N8VEM_ROM_SIZE);