From f0bee7f28e74aa7218b02ad7479687322c6cb247 Mon Sep 17 00:00:00 2001 From: Bob Supnik Date: Wed, 15 Mar 2017 21:00:34 -0700 Subject: [PATCH] VAX750: Fixed bad test for UBA intr level (COVERITY) IPL_UBA already has the subtract built in: So it shouldn't be extracted again. The whole routine looks a little strange, but the way it works is that an interrupt from the UBA itself sets in the returned vector. Because the vector is read by code and not used by hardware, the flag bit is "harmless." UBA interrupts occur only under strange circumstances, like bad map pages and device NXMs. Under the simulator, with a debugged OS, they never happen. --- VAX/vax750_uba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VAX/vax750_uba.c b/VAX/vax750_uba.c index 16779b2c..35e61123 100644 --- a/VAX/vax750_uba.c +++ b/VAX/vax750_uba.c @@ -422,7 +422,7 @@ int32 uba_get_ubvector (int32 lvl) { int32 i; -if ((lvl == (IPL_UBA - IPL_HMIN)) && uba_int) { /* UBA lvl, int? */ +if ((lvl == IPL_UBA) && uba_int) { /* UBA lvl, int? */ uba_int = 0; /* clear int */ } for (i = 0; int_req[lvl] && (i < 32); i++) {