From f94c8b259ad1ef82f79c5baa7c8123e9fae942d5 Mon Sep 17 00:00:00 2001 From: Mark Pizzolato Date: Mon, 11 Sep 2017 15:46:56 -0700 Subject: [PATCH] S2: Fix Coverity identified potential buffer overflow --- S3/s3_sys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/S3/s3_sys.c b/S3/s3_sys.c index 15a76ed2..dfc3cbb3 100644 --- a/S3/s3_sys.c +++ b/S3/s3_sys.c @@ -926,11 +926,11 @@ return (-(oplen-1)); CONST char *parse_addr(CONST char *cptr, char *gbuf, t_addr *addr, int32 *addrtype) { int32 nybble = 0; -char temp[32]; +char temp[CBUFSIZE]; cptr = get_glyph(cptr, gbuf, ','); if (gbuf[0] == '(') { /* XR relative */ - strcpy(temp, gbuf+1); + strlcpy(temp, gbuf+1, sizeof(temp)); sscanf(temp, "%x", addr); if (*cptr == ',') cptr++; cptr = get_glyph(cptr, gbuf, ',');