Commit graph

3827 commits

Author SHA1 Message Date
Bob Supnik
cc2c8f10fc I7094: Fix typo in accessing unit array (COVERITY) 2017-04-07 11:06:28 -07:00
Bill Beech
60bf7d5d12 IBMPC, IBMPCXT: Compiler suggested cleanup 2017-04-07 10:23:55 -07:00
Mark Pizzolato
d42dd707e9 VAX750: Fix some 750 UBA inconsistencies 2017-04-06 18:12:44 -07:00
Mark Pizzolato
1c83826b43 ID32: Fix potential uninitialized variable recording history (COVERITY) 2017-04-06 18:11:33 -07:00
Bill Beech
2ddb7162f3 ibmpc & Intel systems: Fix coverity identified issues 2017-04-05 12:51:28 -07:00
Bill Beech
861d460ce5 SWTP: remove error path extra close (COVERITY) 2017-04-05 12:48:52 -07:00
Mark Pizzolato
c48b254228 ETHER: Fix packet length check to properly accomodate CRC data if needed
As discussed in #419
2017-04-03 14:49:54 -07:00
Mark Pizzolato
00f6cd59a2 SCP: Make sure that SCPE_OK isn't interpreted as error in sim_messagef
Error status returns cause the line in a DO file to be displayed.  This
should only happen for non SCPE_OK status.
2017-04-03 12:56:48 -07:00
Mark Pizzolato
9b2ff7e371 SCP: Add COPY/CP command 2017-04-03 08:26:25 -07:00
Peter Schorn
17903827bd AltairZ80: Mark Coverity false positives in rotate operations 2017-04-01 08:48:43 +02:00
Mark Pizzolato
064c8e54a8 SCP: Silence Coverity warnings 2017-03-31 18:54:18 -07:00
Mark Pizzolato
3af3a8ea54 SLIRP:: Coverity cleanup 2017-03-31 17:48:30 -07:00
Bob Supnik
b9543529d2 All VAX: Fixed uninitialized variable on FPD path (COVERITY) 2017-03-31 15:02:34 -07:00
Howard M. Harte
92386549bd TX-0: Address CID 1415866 deadcode error. 2017-03-31 08:12:33 -07:00
Mark Pizzolato
fa1671455e All VAX: Avoid potential invalid memory reference recording history after FPD 2017-03-30 19:22:16 -07:00
Mark Pizzolato
680ad4f239 Various VAX: Mark Coverity False Positive for boot command parsing 2017-03-30 19:20:48 -07:00
Mark Pizzolato
8344225aef ALTAIR: Leave room for NUL byte in the degenerate case (COVERITY) 2017-03-30 12:54:23 -07:00
Mark Pizzolato
773cc1c319 SCP: Minor Coverity cleanup 2017-03-30 07:55:13 -07:00
Bob Supnik
c97f466457 PDP8: Annotate fall through paths in switch statements
The code is a bit difficult to understand, but it represents the 'normal'
path for processing a DECtape word. The code always flows all the
way to the break.

For start of block, there's extra code to check for a timing error; but
then the first word is processed (case 0).

For a normal word, a 3-cycle data break is done - increment word
count and current address, check for word count overflow, put the
word in the buffer; but then check for end of block (case DTO_WCO).

If the word count has already overflowed,  just check for end of block.

So yes, the end of case 0 should be labeled 'fall through' as well.

FNC_WRIT has the same structure and needs the same comment.
2017-03-30 07:12:57 -07:00
Mark Pizzolato
c2c1f04e8a ALTAIR: Avoid potential buffer overrun while parsing opcodes and arguments 2017-03-29 14:16:57 -07:00
John Forecast
d4a79a27b0 CDC1700: Provide scripts to install and run MSOS 2017-03-29 14:09:54 -07:00
Mark Pizzolato
2b0acc301a DISK: Ignore potential cleanup errors and avoid sign extension byte swapping 2017-03-29 08:19:17 -07:00
Mark Pizzolato
a9a91420b0 SCP: Properly define sim_name array to avoid potential overrun 2017-03-29 07:43:11 -07:00
Mark Pizzolato
62dc8ff6ec ALTAIR: Fix potential reference to uninitialized memory (Coverity) 2017-03-29 07:04:29 -07:00
Mark Pizzolato
fa7e350c78 SCP: Avoid potential invalid pointer reference (Coverity) 2017-03-29 07:02:46 -07:00
Mark Pizzolato
cb6b0a526a SCP: Coverity warning cleanup 2017-03-28 22:35:26 -07:00
Mark Pizzolato
8d8a286c58 SCP: Add checks to avoid potential buffer overrun (Coverity) 2017-03-28 19:36:12 -07:00
Bob Supnik
d60c56d18f PDP10: Add fall through comment to case (COVERITY) 2017-03-28 19:27:27 -07:00
Bob Supnik
5896b1c20d PDP10: Documented switch fall through case (COVERITY) 2017-03-28 14:32:10 -07:00
Mark Pizzolato
3989251f85 SCP: Add more Error path checks 2017-03-28 13:40:11 -07:00
Mark Pizzolato
36f09d223f SCP: Fix potential error return checks (COVERITY) 2017-03-28 13:34:19 -07:00
Holger Veit
3e54264253 SAGE: Fix flag setting with 33bit mask 2017-03-28 13:32:22 -07:00
Mark Pizzolato
d98564544e SLIRP: silence Coverity noise 2017-03-27 20:48:27 -07:00
Mark Pizzolato
f4b7d1fbf8 SCP: Migrate some use of strcat() to sim_strlcat() 2017-03-27 08:23:03 -07:00
Mark Pizzolato
ec11ecab87 PDQ3: Fix coverity issue 1416165
Avoid potential buffer overrun using strcat() by using strlcat()
2017-03-27 07:54:07 -07:00
Mark Pizzolato
34d29d3160 SCP: Add sim_strlcpy and sim_strlcat for platforms missing strlcpy and strlcat 2017-03-27 07:51:13 -07:00
Holger Veit
9a9b5deb9c PDQ-3, SAGE: Coverity Fixes
CID       Action
   1416081   changed variable answer to int
   1416082   checked returned values with ASSURE - read error means corrupted target code.
   1416088   added return
   1416109   This fallthru was intentional - duplicated code to make coverity happy
   1416111   This fallthru was intentional - duplicated code to make coverity happy
   1416116   This fallthru was intentional - duplicated code to make coverity happy
   1416117   This fallthru was intentional - duplicated code to make coverity happy
   1416124   protected against negative return
   1416142   added ASSURE, however this case won't happen since reg_intpending==true implies positive int level
   1416145   checked non-NULL, return SCPE_ARG if NULL
   1416150   since only 2 drives are supported, fdc_selected is decoded to 0 and 1 only (allowed 2 and 3 before)
   1416152   restrict to 2 drives only
   1416166   checked value with ASSURE

   1416101   typo: should have been resx
   1416106   unnecessary code removed
   1416110   this fallthru was intentional - duplicated code to make coverity happy
   1416112   this fallthru was intentional - duplicated code to make coverity happy
   1416148   change condition to check for negative value
   1416179   break was remainder from former logic - removed
   1415866   code was remainder from former unimplemented instruction trap - removed
2017-03-27 06:57:43 -07:00
Mark Pizzolato
489752596b SLIRP: Coverity identified warning 2017-03-26 11:49:05 -07:00
Mark Pizzolato
c638950211 PDP11: Properly handle reads of less than 1 sector
Fix #412, #424
2017-03-26 06:52:21 -07:00
Mark Pizzolato
b2cd329f4c FRONTPANEL: Fix repeating register data gathering lock problem (COVERITY) 2017-03-20 23:37:50 -07:00
Mark Pizzolato
2d1b969cb7 TAPE: Stub extended gap behaviors to avoid link time errors. 2017-03-20 23:05:47 -07:00
Bob Supnik
3eb4598456 SCP: Removed KBD_WAIT and friends 2017-03-20 22:33:38 -07:00
Bill Beech
0947a69a9e isys80xx, imds-225: Cleanup Coverity identified issues 2017-03-20 13:41:24 -07:00
Bill Beech
f02a9b02f3 ibmpc, ibmpcxt: Cleanup Coverity identified issues 2017-03-20 13:40:40 -07:00
Bill Beech
bef62a51fd SWTP: Cleanup Coverity identified issues 2017-03-20 13:32:43 -07:00
Mark Pizzolato
6831746400 All VAX: Clarify Opcode Table decode values
the opcode table first word consists of bits:

<7> = FPD is legal for this opcode.
<4:6> = number of specifiers for unimplemented opcodes (VAX subsets)
<3> = unused
<0:2> = number of specifiers

The mask used to be 0x70. The convention is that x_M_y is a mask value
<right-justified>, for a macro like:

#define get_foo(x)        (((x) >> x_V_foo) & x_M_foo)

For a subset VAX (like the 3900), the unimplemented opcodes are those
2017-03-20 08:10:43 -07:00
Bob Supnik
33f02ae4d7 SDS: Add precise gap erase to MT device
As discussed in #152.  Still needs some additional sim_tape work.
2017-03-20 08:03:49 -07:00
Bob Supnik
0cc2a469b2 sigma: Add "Sigma 7 BigMem" as a model variant
BigMem is a Sigma 9 memory management retrofit to the Sigma 7.
2017-03-20 08:02:57 -07:00
Bob Supnik
c26c6ea501 NOVA, PDP1,, sigma: Various cosmetic/typo changes 2017-03-20 08:01:58 -07:00
Bob Supnik
41ea29a752 PDP18B: Limit connection poll to configured lines 2017-03-20 07:49:03 -07:00