Commit graph

2309 commits

Author SHA1 Message Date
Mark Pizzolato
df1baf2528 CDC1700: Release 2
- Fix protect fault for 2-word instructions so that background tasks do not
   crash.
- Lay the ground work for supporting the enhanced instruction set.
- Fix disk layout bug (disks are no longer compatible with previous version).
- Add debugging support for displaying MSOS 5 system requests.
- Fix bugs found by Coverity.
2017-03-14 13:36:57 -07:00
Mark Pizzolato
ca19ac921c SCP: Fix potential NULL pointer dereference (COVERITY) 2017-03-14 10:24:18 -07:00
Peter Schorn
9f746cfefa AltairZ80: Improved diskClose error handling (Coverity Scan) 2017-03-14 18:12:27 +01:00
Bob Supnik
e7a38cc56f PDP11: Fixed spurious interrupt when setting GO
The code wasn't handling interrupts correctly when TCCM was written. In
particular, if the GO bit clears DONE, the code looked for the "SET IE" case
too soon and didn't clear the interrupt that was incorrectly generated.
The new code factors "GO" into the calculation.
2017-03-14 09:59:14 -07:00
Bob Supnik
aef66264de I1401: Fixed possible NULL pointer dereference (COVERITY) 2017-03-14 04:48:58 -07:00
Bob Supnik
f586105051 I1620: Fix Coverity identified problems
CPU: Added error test on device addr
DP:    Fixed bug in write check function test
TTY:  Fixed tab stop array overrun at right margin
2017-03-14 04:48:14 -07:00
Bob Supnik
b95e8704d2 I7094: Fixed GET_PCHAIN macro (COVERITY) 2017-03-14 04:47:27 -07:00
Bob Supnik
0c03efb560 sigma: Fix Coverity identified problems
CIS:   Properly clear sign
DP:   Fixed bug in selecting 3281 unit F
RTC: Fixed bugs in set, show_tps
2017-03-14 04:46:42 -07:00
Bob Supnik
430541bda9 All VAX: Fixed dangling else in show_opnd (COVERITY) 2017-03-14 04:34:36 -07:00
Bob Supnik
71479d6c0b All VAX: Fixed certain indirect cases in parse (COVERITY) 2017-03-14 04:32:50 -07:00
Mark Pizzolato
f52b5346fa Visual Studio Projects: Add project for imds-225 simulator 2017-03-14 03:52:36 -07:00
Bill Beech
a221ac4055 Intel-Systems, IBMPC: Standardize to CRLF line endings and spaces for tabs 2017-03-13 19:42:55 -07:00
Mark Pizzolato
18efafe927 SCP: Fix remaining memory leak in RESTORE (COVERITY) 2017-03-13 17:56:18 -07:00
Bob Supnik
950fc82e38 VAX780, VAX8600: Fixed bad test for UBA intr level (COVERITY)
IPL_UBA already has the subtract built in:

So it shouldn't be extracted again.

The whole routine looks a little strange, but the way it works is
that an interrupt from the UBA itself sets <bit 31> in the returned vector.
Because the vector is read by code and not used by hardware, the flag
bit is "harmless."

UBA interrupts occur only under strange circumstances, like bad map
pages and device NXMs. Under the simulator, with a debugged OS, they
never happen.
2017-03-13 17:41:09 -07:00
Mark Pizzolato
de95d5bec1 SCP: Fix memory leak in error paths of RESTORE command (COVERITY) 2017-03-13 17:25:42 -07:00
Bill Beech
a943737ab4 isys8010, isys8020, isys8024, isys8030, imds-225: Coverity identified problems
Corrected disk controller behaviors.
2017-03-13 16:57:26 -07:00
Bill Beech
f10f8bc9c5 SWTP6800: Address Converity identified problems 2017-03-13 16:55:13 -07:00
Bill Beech
a3a1db40fe IBMPC: Minor cleanup and change to CRLF line endings 2017-03-13 16:29:16 -07:00
Peter Schorn
30556c8d78 AltairZ80: Fix uninitialized variable (Coverity Scan) 2017-03-13 21:59:37 +01:00
Mark Pizzolato
979aec293e SLIRP: Fix potential NULL pointer dereference and excess left shift (COVERITY) 2017-03-13 12:58:40 -07:00
Bob Supnik
d1768d2771 PDP10, PDP11, PDP18B, PDP8: Annotate switch case fall through (COVERITY) 2017-03-13 10:59:06 -07:00
Bob Supnik
fa62a00fd0 GRI, H316, I7094, NOVA, SDS, sigma: Annotate switch case fall through (COVERITY) 2017-03-13 10:44:51 -07:00
Bob Supnik
6333555947 VAX: Annotated intentional fall throughs in switch statements (COVERITY) 2017-03-13 10:37:39 -07:00
Mark Pizzolato
4da04e06ce PDP11, VAX: Fix RQ device potential memory reference errors (COVERITY) 2017-03-12 19:41:23 -07:00
Richard Cornwell
5efbd203a3 B5500: Fixed Coverity errors, and fixed for current SCP. 2017-03-12 22:33:06 -04:00
Mark Pizzolato
14b9265af3 PDP11, VAX: Cleaned MSCP/TMSCP packet queues to be uint16 2017-03-12 19:06:46 -07:00
Mark Pizzolato
12f43e660f TIMER: Behave reasonably when a simulator doesn't associate a UNIT with a timer 2017-03-12 17:59:23 -07:00
Peter Schorn
bd575651ca AltairZ80: More fixes from source code scan (Coverity Scan) 2017-03-12 18:21:07 +01:00
Peter Schorn
70a8921a7a AltairZ80: Fix various static source scanning detected issues (Coverity Scan) 2017-03-12 12:06:05 +01:00
Sergey Svishchev
e49f06dcc3 AltairZ80: fix out-of-bounds accesses (Coverity Scan) 2017-03-11 23:48:03 -08:00
Mark Pizzolato
ba527ab24a Intel-Systems: Fix prior - plug file descriptor leaks (Coverity Scan) 2017-03-11 22:28:33 -08:00
Mark Pizzolato
aa0924816a PDP11, VAX: Fix RQ device Endian compatibility problem (COVERITY) 2017-03-11 22:24:41 -08:00
Mark Pizzolato
c4e963921b PDP11, VAX: Fix TQ device Endian compatibility problem (COVERITY) 2017-03-11 22:23:38 -08:00
Sergey Svishchev
edc93cf263 CDC1700: fix potential use of uninitialized value (Coverity Scan) 2017-03-11 17:59:41 -08:00
Sergey Svishchev
12bd47eb02 Intel-Systems: plug file descriptor leaks (Coverity Scan) 2017-03-11 16:16:34 -08:00
Mark Pizzolato
c6ed19aec3 PDP11, VAX780: XU device fixes (COVERITY)
- Fix potential beyond array bounds memory references
- Fix layout of Read System Id Parameter block (diagnostics)
2017-03-11 16:04:56 -08:00
Mark Pizzolato
235a39714c PDP11, VAX: XQ device fixes (COVERITY)
- Fix potential beyond array bounds memory references
- Fix MOP protocol packet parsing
2017-03-11 16:00:00 -08:00
Mark Pizzolato
65f8e72b40 SCP: Fix uninitialized variable referenced in help (COVERITY) 2017-03-11 12:44:04 -08:00
Mark Pizzolato
7eece3deb1 SCP: Allow detaching of buffered devices without a buffer (COVERITY) 2017-03-11 11:10:56 -08:00
Mark Pizzolato
c169b8dd79 ALTAIR: Extend disk buffer by 1 byte to avoid array overruns (COVERITY) 2017-03-11 10:10:15 -08:00
Mark Pizzolato
44deef9447 VAX780: Fix potentially uninitialized variable reference (COVERITY) 2017-03-11 09:50:39 -08:00
Mark Pizzolato
2d5711961f ETHER: Fix potential unterminated string (COVERITY) 2017-03-11 09:17:40 -08:00
Mark Pizzolato
c94659571f ETHER: Fix potential unterminated string and packet buffer overrun (COVERITY) 2017-03-11 03:14:33 -08:00
Mark Pizzolato
9731644495 SCP: Fix Coverity identified problems
- Use memmove instead of memcpy for potentially overlapping moves.
- Fix memory leaks in error paths.
- Fix potential NULL pointer references
- Assure that string copies stay within bounds of the destination string and
  are NUL terminated
- Fix NULL pointer dereferencing in help routines
2017-03-11 02:33:22 -08:00
Mark Pizzolato
8df467835a DISK: generalized data debug routine for use by devices that don't use sim_disk 2017-03-11 00:13:34 -08:00
Mark Pizzolato
9f929ae312 DISK: Fix Coverity identified problems
Replace memcpy with memmove for overlapping buffer moves.
VHD differencing disk parent filename fix
fix sizing of SIMH format disk drives
Fix memory leak after initializing a disk with a pattern
Fix bad 144 block initialization for RB and CS devices
2017-03-10 15:59:37 -08:00
Mark Pizzolato
872b2f238d TAPE: Fix potential NULL references (COVERITY) 2017-03-10 12:01:38 -08:00
Mark Pizzolato
009e5061e2 PDP11, PDP10: Fix DUP Modem signal change logic (COVERITY) 2017-03-10 11:55:30 -08:00
Mark Pizzolato
7af3e357f0 PDP11, VAX: Fix debug output state reference (COVERITY) 2017-03-10 11:55:30 -08:00
Mark Pizzolato
df3f49c7a0 MicroVAX1: Fix NULL reference check in boot command parsing (COVERITY) 2017-03-10 11:55:29 -08:00