folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PDP18B: Compiler warning cleanup

Browse source 
- Remove unused variable assignment
- Avoid potential out of array indexing due to theoretical array
  reference via signed char index.  Likely non functional change.
This commit is contained in:
Mark Pizzolato 2020-10-19 12:31:02 -07:00
parent 7bdb5aee8d
commit 46133b5dd8
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PDP18B/pdp18b_dr15.c
View file

@ -141,8 +141,6 @@ DEVICE dr15_dev = {
int32 dr60 (int32 dev, int32 pulse, int32 AC) int32 dr60 (int32 dev, int32 pulse, int32 AC)
{ {
int32 subdev = (pulse >> 4) & 03;
if (((pulse & 01) != 0) && (dr15_tcb_ack != 0)) /* SIOA */ if (((pulse & 01) != 0) && (dr15_tcb_ack != 0)) /* SIOA */
AC |= IOT_SKP; AC |= IOT_SKP;
if ((pulse & 02) != 0) /* CIOP */ if ((pulse & 02) != 0) /* CIOP */

4
PDP18B/pdp18b_lp.c
View file

@ -834,10 +834,10 @@ for (more = 1; more != 0; ) { /* loop until ctrl */
ccnt = 5; ccnt = 5;
} }
for (i = 0; i < ccnt; i++) { /* loop through */ for (i = 0; i < ccnt; i++) { /* loop through */
if ((c[i] <= 037) && ctrl[c[i]]) { /* control char? */ if ((c[i] <= 037) && ctrl[c[i] & 037]) { /* control char? */
lp15_buf[lp15_bp] = 0; /* append nul */ lp15_buf[lp15_bp] = 0; /* append nul */
fputs (lp15_buf, uptr->fileref); /* print line */ fputs (lp15_buf, uptr->fileref); /* print line */
fputs (ctrl[c[i]], uptr->fileref); /* space */ fputs (ctrl[c[i] & 037], uptr->fileref); /* space */
uptr->pos = ftell (uptr->fileref); uptr->pos = ftell (uptr->fileref);
if (ferror (uptr->fileref)) { /* error? */ if (ferror (uptr->fileref)) { /* error? */
sim_perror ("LPT I/O error"); sim_perror ("LPT I/O error");