SCP: Clear Coverity identified warnings

This commit is contained in:
Mark Pizzolato 2019-11-14 21:38:45 -08:00
parent fc785ab5f9
commit 7c1c04d9a9
3 changed files with 4 additions and 3 deletions

3
scp.c
View file

@ -2865,7 +2865,8 @@ fprintf (st, " HELP dev SET\n");
fprintf (st, " HELP dev SHOW\n"); fprintf (st, " HELP dev SHOW\n");
fprintf (st, " HELP dev REGISTERS\n\n"); fprintf (st, " HELP dev REGISTERS\n\n");
fprintf (st, "Help is available for the following commands:\n\n "); fprintf (st, "Help is available for the following commands:\n\n ");
qsort (hlp_cmdp, cmd_cnt, sizeof(*hlp_cmdp), _cmd_name_compare); if (hlp_cmdp)
qsort (hlp_cmdp, cmd_cnt, sizeof(*hlp_cmdp), _cmd_name_compare);
line_offset = 4; line_offset = 4;
for (i=0; i<cmd_cnt; ++i) { for (i=0; i<cmd_cnt; ++i) {
fputs (hlp_cmdp[i]->name, st); fputs (hlp_cmdp[i]->name, st);

View file

@ -448,8 +448,8 @@ return port;
void sim_close_serial (SERHANDLE port) void sim_close_serial (SERHANDLE port)
{ {
sim_close_os_serial (port);
_serial_remove_from_open_list (port); _serial_remove_from_open_list (port);
sim_close_os_serial (port);
} }
t_stat sim_config_serial (SERHANDLE port, CONST char *sconfig) t_stat sim_config_serial (SERHANDLE port, CONST char *sconfig)

View file

@ -4232,7 +4232,7 @@ static void ansi_fill_text_buffer (FILE *f, char *buf, size_t buf_size, size_t r
if (rec_size >= record_skip_ending) if (rec_size >= record_skip_ending)
rec_size -= record_skip_ending; rec_size -= record_skip_ending;
if ((rec_size + 4) > (int)(buf_size - offset)) { /* room for record? */ if ((rec_size + 4) > (int)(buf_size - offset)) { /* room for record? */
fseek (f, start, SEEK_SET); (void)fseek (f, start, SEEK_SET);
break; break;
} }
sprintf (rec_size_str, "%04u", (int)(rec_size + 4)); sprintf (rec_size_str, "%04u", (int)(rec_size + 4));