folkert/simh-testsetgenerator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

VAX750: Fixed bad test for UBA intr level (COVERITY)

Browse source 
IPL_UBA already has the subtract built in:

So it shouldn't be extracted again.

The whole routine looks a little strange, but the way it works is
that an interrupt from the UBA itself sets <bit 31> in the returned vector.
Because the vector is read by code and not used by hardware, the flag
bit is "harmless."

UBA interrupts occur only under strange circumstances, like bad map
pages and device NXMs. Under the simulator, with a debugged OS, they
never happen.
This commit is contained in:
Bob Supnik 2017-03-15 21:00:34 -07:00 • committed by Mark Pizzolato
parent 8d8ecc1a5a
commit f0bee7f28e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
VAX/vax750_uba.c
View file

@ -422,7 +422,7 @@ int32 uba_get_ubvector (int32 lvl)
{
int32 i;
if ((lvl == (IPL_UBA - IPL_HMIN)) && uba_int) { /* UBA lvl, int? */
if ((lvl == IPL_UBA) && uba_int) { /* UBA lvl, int? */
uba_int = 0; /* clear int */
}
for (i = 0; int_req[lvl] && (i < 32); i++) {