Commit graph

2401 commits

Author SHA1 Message Date
Mark Pizzolato
490b4d0583 PDP4, PDP7, PDP9: Add another fall through comment (Coverity) 2017-04-28 14:11:46 -07:00
Bill Beech
357910dfb9 imds-224, isys80xx: Rework attach routines to leverage SCP provided functionality 2017-04-27 11:20:12 -07:00
Mark Pizzolato
0586d34f16 PDP4, PDP7, PDP9: Add fall through comment (Coverity) 2017-04-27 02:11:52 -07:00
Mark Pizzolato
47c917a55d PDP11, VAX: Fix stray TABs which crept in over time 2017-04-26 15:42:36 -07:00
Matt Burke
7092c55907 VAX750: Fixes to Unibus adapter to address #346
Modified the UBA750 simulation, incorporating these comments. Ultrix
appears to access the non-existant datapath registers and given that this
works on the real hardware the most likely option seems to be read 0
and write NOP. I think this will be true for any access to the UBI outside
of the known registers.
2017-04-26 15:36:28 -07:00
Matt Burke
4b41b3372f All VAX, PDP11, PDP10: Minor fixes to DZ device 2017-04-26 15:34:01 -07:00
Matt Burke
f6d4e92c6d VAX8600: Marked intentional fall through of case statement CID: 1415576 2017-04-26 15:27:44 -07:00
Matt Burke
a3e6aac076 All VAXStations: Fixed logical vs bitwise operator CID: 1415454
Tested with VWS, UWS and DECwindows. This QVSS issue only affected polled
interrupt mode, which is likely not used by most operating systems
2017-04-26 15:25:55 -07:00
Mark Pizzolato
b5a5aec57a SCP: Avoid potential macro redefinition for strcasecmp() and strncasecmp() 2017-04-24 13:44:40 -07:00
Mark Pizzolato
1a8bc50130 PDP11, Qbus VAX: Add delay when starting XQ device in DELQA-T mode 2017-04-24 13:25:10 -07:00
Mark Pizzolato
e522daf906 SCP: Replace stray TAB and fix sprintf format specifier 2017-04-23 23:43:14 -07:00
Matt Burke
c94edb6b2d VAXStations: Improvements and bug fixes to keyboard and mouse devices
Whilst working on a new video device I ran into a few problems with the
LKxxx keyboard and I noticed there are already some open issues against
the keyboard and mouse devices. These changes should resolve #320 and
may help with #272 (although I think that is an SDL issue). I've tested these
changes with VWS, UWS and DECwindows with both captured and
uncaptured input modes.
2017-04-23 10:40:00 -07:00
Mark Pizzolato
168d0d9c47 SCP: add generic length limted and case independent string for all platforms 2017-04-22 21:28:48 -07:00
Mark Pizzolato
9179c4ea07 SCP: Fix OS Error text routine on Windows with gcc 2017-04-22 15:43:09 -07:00
Bob Supnik
a719ef51e8 alpha: Fixed function field widths (Maurice Marks)
Maurice Marks, at VMS Software Inc, is using the Alpha instruction emulator
from SimH as a backup to an Alpha binary translator! He found a bug in the
instructions definitions: function fields, both integer and floating, are 7b not
6b.
2017-04-17 10:10:03 -07:00
Mark Pizzolato
c4931bbd30 PDP11: Fix error path check on disk I/O status 2017-04-13 21:55:40 -07:00
Mark Pizzolato
8c5305c857 PDP11: Fix rounding up sector count computation
Fix #412, #424
2017-04-13 20:42:47 -07:00
Mark Pizzolato
cd8e9eb5da PDP11: Properly handle reads of less than 1 sector
Fix #412, #424
2017-04-13 18:20:01 -07:00
Mark Pizzolato
faae90e160 ID16: Fix potential uninitialized variable recording history (COVERITY) 2017-04-11 11:03:41 -07:00
Mark Pizzolato
6ff3eeac80 SCP: Compiler suggested cleanup 2017-04-10 10:47:42 -07:00
Bill Beech
2b30084a53 IBMPC, IBMPCXT, isys80xx: Restructure directories to eliminate redundant files 2017-04-10 10:32:43 -07:00
Mark Pizzolato
7317645dd7 SCP: Make COPY command more robust 2017-04-07 14:35:04 -07:00
Ryo ONODERA
64376cad58 makefile: Use correct variable name, FONTPATH instead of FONTNAME in message 2017-04-07 11:25:27 -07:00
Mark Pizzolato
c6b10a06de makefile: Add check for utime.h 2017-04-07 11:23:05 -07:00
Bob Supnik
cc2c8f10fc I7094: Fix typo in accessing unit array (COVERITY) 2017-04-07 11:06:28 -07:00
Bill Beech
60bf7d5d12 IBMPC, IBMPCXT: Compiler suggested cleanup 2017-04-07 10:23:55 -07:00
Mark Pizzolato
d42dd707e9 VAX750: Fix some 750 UBA inconsistencies 2017-04-06 18:12:44 -07:00
Mark Pizzolato
1c83826b43 ID32: Fix potential uninitialized variable recording history (COVERITY) 2017-04-06 18:11:33 -07:00
Bill Beech
2ddb7162f3 ibmpc & Intel systems: Fix coverity identified issues 2017-04-05 12:51:28 -07:00
Bill Beech
861d460ce5 SWTP: remove error path extra close (COVERITY) 2017-04-05 12:48:52 -07:00
Mark Pizzolato
c48b254228 ETHER: Fix packet length check to properly accomodate CRC data if needed
As discussed in #419
2017-04-03 14:49:54 -07:00
Mark Pizzolato
00f6cd59a2 SCP: Make sure that SCPE_OK isn't interpreted as error in sim_messagef
Error status returns cause the line in a DO file to be displayed.  This
should only happen for non SCPE_OK status.
2017-04-03 12:56:48 -07:00
Mark Pizzolato
9b2ff7e371 SCP: Add COPY/CP command 2017-04-03 08:26:25 -07:00
Peter Schorn
17903827bd AltairZ80: Mark Coverity false positives in rotate operations 2017-04-01 08:48:43 +02:00
Mark Pizzolato
064c8e54a8 SCP: Silence Coverity warnings 2017-03-31 18:54:18 -07:00
Mark Pizzolato
3af3a8ea54 SLIRP:: Coverity cleanup 2017-03-31 17:48:30 -07:00
Bob Supnik
b9543529d2 All VAX: Fixed uninitialized variable on FPD path (COVERITY) 2017-03-31 15:02:34 -07:00
Howard M. Harte
92386549bd TX-0: Address CID 1415866 deadcode error. 2017-03-31 08:12:33 -07:00
Mark Pizzolato
fa1671455e All VAX: Avoid potential invalid memory reference recording history after FPD 2017-03-30 19:22:16 -07:00
Mark Pizzolato
680ad4f239 Various VAX: Mark Coverity False Positive for boot command parsing 2017-03-30 19:20:48 -07:00
Mark Pizzolato
8344225aef ALTAIR: Leave room for NUL byte in the degenerate case (COVERITY) 2017-03-30 12:54:23 -07:00
Mark Pizzolato
773cc1c319 SCP: Minor Coverity cleanup 2017-03-30 07:55:13 -07:00
Bob Supnik
c97f466457 PDP8: Annotate fall through paths in switch statements
The code is a bit difficult to understand, but it represents the 'normal'
path for processing a DECtape word. The code always flows all the
way to the break.

For start of block, there's extra code to check for a timing error; but
then the first word is processed (case 0).

For a normal word, a 3-cycle data break is done - increment word
count and current address, check for word count overflow, put the
word in the buffer; but then check for end of block (case DTO_WCO).

If the word count has already overflowed,  just check for end of block.

So yes, the end of case 0 should be labeled 'fall through' as well.

FNC_WRIT has the same structure and needs the same comment.
2017-03-30 07:12:57 -07:00
Mark Pizzolato
c2c1f04e8a ALTAIR: Avoid potential buffer overrun while parsing opcodes and arguments 2017-03-29 14:16:57 -07:00
John Forecast
d4a79a27b0 CDC1700: Provide scripts to install and run MSOS 2017-03-29 14:09:54 -07:00
Mark Pizzolato
2b0acc301a DISK: Ignore potential cleanup errors and avoid sign extension byte swapping 2017-03-29 08:19:17 -07:00
Mark Pizzolato
a9a91420b0 SCP: Properly define sim_name array to avoid potential overrun 2017-03-29 07:43:11 -07:00
Mark Pizzolato
62dc8ff6ec ALTAIR: Fix potential reference to uninitialized memory (Coverity) 2017-03-29 07:04:29 -07:00
Mark Pizzolato
fa7e350c78 SCP: Avoid potential invalid pointer reference (Coverity) 2017-03-29 07:02:46 -07:00
Mark Pizzolato
cb6b0a526a SCP: Coverity warning cleanup 2017-03-28 22:35:26 -07:00