Commit graph

4228 commits

Author SHA1 Message Date
Mark Pizzolato
aa637f58c0 DISK: Properly support attach time disk copy to a larger container 2022-03-17 07:28:11 -07:00
Leo Broukhis
36cd4668e7 BESM6: A Coverity fix, TTY enhancements.
One of the two parallel interface consoles (TTY26) works in the Videoton-340 mode;
disconnecting a remote TTY session works like powering the terminal down.
After reconnecting, it is necessary to type "HYC" blindly to re-initialize the line.
Added TMXR line reordering.
2022-03-16 19:52:51 -07:00
Mark Pizzolato
8d2e6849b6 I7094: Remove irrelevant buffer address checks
These checks were remnants of prior code which dynamically allocated buffers.
2022-03-16 19:18:22 -07:00
Mark Pizzolato
50f80f61cf PDP11: Only compute vector ilvl when it will be used (Coverity) 2022-03-16 14:44:20 -07:00
Bill Beech
efa04e4e31 SWTP: Fix Coverity found more missing arguments in M6800 2022-03-16 14:41:34 -07:00
Bob Armstrong
2a63d939d3 H316: Coverity update - remove dead code; fix formatting 2022-03-16 10:56:21 -07:00
Richard Cornwell
3d3675edbc KA10: Clean up coverity error. 2022-03-15 21:30:55 -04:00
Bill Beech
af6665be05 SWTP: Fix Coverity found missing argument in M6800 2022-03-15 15:44:13 -07:00
SpareTimeGizmos
b779bfc1cd H316: Fix missing initialization and remove dead code found by Coverity 2022-03-15 08:35:47 -07:00
Mark Pizzolato
d03f1b67a2 PDP11: Only compute vector ibit when it will be used (Coverity) 2022-03-15 08:19:25 -07:00
Mark Pizzolato
b6201898ee I1620: Fix typo in recent Coverity change 2022-03-15 07:48:20 -07:00
Mark Pizzolato
d02e91c797 I1401, I1620, I7094: Address Coverity issues in card reader devices 2022-03-15 07:25:34 -07:00
Howard M. Harte
86f65093bc AltairZ80: s100_hdc1001: Resolve CID 1515006. 2022-03-14 22:43:56 -07:00
Mark Pizzolato
e88221b362 I7094: Avoid Coverity identified potential error 2022-03-14 15:54:02 -07:00
Mark Pizzolato
61c1af846f TAPE: export sim_tape_error_text 2022-03-14 15:28:39 -07:00
Peter Schorn
8f3a2057e1 AltairZ80: Fix Coverity identified issues in s100_jd2d.c 2022-03-14 14:55:50 +01:00
Mark Pizzolato
b2dd269d7a SCP: Expand sprint_val target buffers with one extra byte 2022-03-13 20:08:54 -07:00
Mark Pizzolato
ee545a4828 SCP: Assure that all formatted numbers have sufficient buffer space 2022-03-13 13:23:05 -07:00
Mark Pizzolato
6c16052184 SIGMA: Avoid Coverity mag tape warning 2022-03-13 12:40:16 -07:00
Roberto Sancho Villa
b9cdcd1099 I650: Fix Coverity identified issues 2022-03-13 11:47:08 -07:00
Mark Pizzolato
8c325db1ab Various Magtape Devices: Handle Coverity report of tape error status cases
Coverity flagged one magtape simulator for having fewer case breakouts
than the range of MTSE_x errors, after they were expanded for
MTSE_LEOT (listed as "V4 compatibility") and MTSE_RUNAWAY (for
Dave Bryan's implementation of erase and erase gap).

According to Dave, it turns out that MTSE_RUNAWAY can only be
returned if the magtape simulator supports and implements a density
specification and the ERASE function. The simulators Bob Supnik wrote
don't meet that criteria, so the expanded errors can't be returned.

Simply add a "default" case to the map logic returning SCPE_IERR for
unexpected cases.
2022-03-13 11:23:11 -07:00
Mark Pizzolato
4fa0eaad99 ETHER: Correct reversed supported version check for Npcap 2022-03-12 14:28:24 -08:00
Richard Cornwell
b566ea356f KA10: Cleanup some extended addressing issues with KL10B.
Clean up coverity errors.
2022-03-12 15:48:49 -05:00
Seth Morabito
c117a0bd06 3b2: Fix Coverity issues 2022-03-12 11:38:07 -08:00
Mark Pizzolato
56688be951 SWTP6800: Fix Coverity issue 2022-03-12 07:58:04 -08:00
Leo Broukhis
8ae7d4fbcd BESM6: Coverity fixes, added disk type display for SHOW MDn. 2022-03-11 19:49:28 -08:00
Mark Pizzolato
070e0b3f22 PDP10: Fix LP DEVICE attach logic remove redundant code done by SCP 2022-03-11 16:25:08 -08:00
Mark Pizzolato
bfa200f2ed IBM1130: Fix Coverity identified issue 2022-03-11 13:29:26 -08:00
Mark Pizzolato
5465707d77 PDP11, VAX: Fix Coverity issues in XQ and XU devices 2022-03-11 12:34:59 -08:00
Lars Brinkhoff
96ac1c4ba0 IMLAC: Fix wrong instruction mask for decoding. 2022-03-11 09:27:07 +01:00
Lars Brinkhoff
5efb47dca5 TT2500: Fix unintended switch case fallthrough. 2022-03-11 09:18:38 +01:00
Mark Pizzolato
c035be465c PDP11: Fix Coverity identified issue in debug format statement 2022-03-10 17:08:15 -08:00
Mark Pizzolato
93e86f31f0 PDP11: Fix Coverity identified issue in HELP CPU 2022-03-10 17:07:11 -08:00
Mark Pizzolato
6ad8a528d7 DISK: Fix a few Coverity issues 2022-03-10 16:44:57 -08:00
Richard Cornwell
9b2f13d443 KA10: Fixed some coverity errors. 2022-03-10 19:12:46 -05:00
AZBevier
894871f64d SEL32: Correct Coverity detected warning errors. 2022-03-10 11:15:00 -07:00
Mark Pizzolato
e3dbe93e35 SCP: Coverity fixes 2022-03-09 15:53:10 -08:00
Bill Beech
a1a916f819 SWTP6800: Fix Coverity reported issue 2022-03-09 16:05:23 -07:00
Bill Beech
c9c9fa641b SWTP6800: General cleanup and boot fixup
DC-4: fixed flags
M6800: simplified code in big instr decode loop, Removed sim-debug
M6810: added examine and deposit (from Thomas Pfau), Removed sim-debug
MP-A: added examine and deposit (from Thomas Pfau)
2022-03-09 15:37:29 -07:00
Howard M. Harte
2cede2fb99 AltairZ80: HDC-1001: Resolve CID 1514860, 1514861. 2022-03-08 12:31:04 -08:00
Howard M. Harte
e293731e35 AltairZ80: Resolve CID 1514796. 2022-03-08 12:29:49 -08:00
Mark Pizzolato
d3fcb706e0 BESM6: Fix type declaration compile issue 2022-03-08 00:05:54 -08:00
Mark Pizzolato
857f725470 SCP: Avoid a Coverity complaint about getenv() 2022-03-08 00:02:07 -08:00
Leo Broukhis
6c56968f15 BESM6: 29 Mb disks (EC-5061, clones of IBM 2314) are now functional.
The OS seems to support them only on device MD4, though.
Native formatting works.
2022-03-07 21:06:57 -08:00
Richard Cornwell
3dd0d03321 KA10: Fixed some compiler warnings on MACOS. 2022-03-06 23:20:19 -05:00
Mark Pizzolato
16042a7b96 PDP11, VAX: Add RF30, RF31, RF71 and RF72 disk types to the RQ simulation
These are added based on simple drive geometry and size information
without any parameters for bad block management (not used in simulation
anyway).
Additionally, RF drives connected to Qbus systems via a KFQSA.  When
connected this way, EACH drive on the DSSI bus appeared to the attached
Qbus system as a separate MSCP controller to the operating system.  This
change does not model that connectivity.
2022-03-06 09:39:26 -08:00
Mark Pizzolato
06c696385f SCP: Coverity inspired changes 2022-03-06 02:11:57 -08:00
Mark Pizzolato
87597ea7f4 makefile: Add imlac and tt2500 to the all target. 2022-03-05 04:34:46 -08:00
Mark Pizzolato
a50dca0ff0 SCP: Normalize writelock/read only behavior
Setting a unit to write locked specifically allows only read access.
- If this is done while a unit is attached, it is up to device logic to
  limit write activity until it is detached.
- If this is done while a unit is not attached, a subsequent attach
  opens the container read only.
2022-03-04 21:13:37 -08:00
Mark Pizzolato
2fb741046d PDP11 & VAX: Avoid RQ DEVICE uname memory leaks
Additional UNITs from 4 up to 254 are replicated from Unit 0.
If the UNIT->uname has already been populated, we could leak memory if
it isn't released before copying from the template UNIT.
2022-03-04 18:28:30 -08:00